WooCommerce API Manager migration by shramee · Pull Request #7 · Freemius/edd-migration

shramee · 2016-11-11T14:24:53Z

REQUIRES V1.4.4 or higher.

Docs: https://docs.woocommerce.com/document/woocommerce-api-manager/

Develop

Feature/woocommerce

Not including the `migrate` directory. Searched and replaced EDD naming with WC…

and correcting `WP_FS__NAMESPACE_WC`

New content provided by Vova over Slack…

Call to undefined function print_awesome_r()

shramee · 2016-11-11T14:26:18Z

Tested with WCAM v1.4.6.3

… with any platform.

vovafeldman · 2016-11-11T16:52:05Z

includes/migration/wc/class-fs-wc-download-migration.php

-
-			return $billing_cycle;
+		private function get_billing_cycle( $id ) {
+			return 'annual';


@shramee does WooCommerce only allow annual billing cycles? Or is that only the case for your store?

Well WooCommerce/WCAM doesn't support billing cycles... only one time payment AFAIK. I think WC Subscriptions plugin allows that...

vovafeldman · 2016-11-11T16:59:05Z

includes/migration/wc/class-fs-wc-migration-endpoint.php

+				"url"              => $url,
+				"plugin_version"   => '2.5.0',
+				"is_premium"       => true,
+				"site_uid"         => 'MoouenVlGG45',


@shramee you need to use $this->get_anonymous_id( $url ), the site_uid must be a unique 32 chars identifier.

vovafeldman · 2016-11-11T17:04:23Z

includes/migration/wc/class-fs-wc-migration-endpoint.php

+				"charset"          => 'UTF-8',
+				"platform_version" => '4.6.1',
+				"php_version"      => '7.0.0',
+				"module_id"        => 'Storefront Pro',


@shramee the module_id have to be the product ID, not the title.

vovafeldman · 2016-11-11T17:06:04Z

includes/migration/wc/class-fs-wc-migration-endpoint.php

+				"platform_version" => '4.6.1',
+				"php_version"      => '7.0.0',
+				"module_id"        => 'Storefront Pro',
+				"email"            => $email,


@shramee there's no point adding new params since maybe_process_api_request() is part of the abstract class and it doesn't expect that argument, and won't do anything with it.

I do see that you added some logic that checks email in validate_params() which is fine. But I don't see that you send the email as part of the migration request in my_edd_activate_license() at samples/module-migration.php.

vovafeldman · 2016-11-12T15:18:35Z

includes/migration/wc/class-fs-wc-migration-endpoint.php

+		 * @param string $name Property to return
+		 * @return mixed|null Value if property exists else null
+		 */
+		public function __get( $name ) {


@shramee why do you need external "magic" access? It's not a good practice in general.

Well, that doesn't expose private values... Just order (protected property) and requests parameters...

In general, if you want to expose specific params, the best practice is adding the relevant getters. In the current context, if you read my comment about the dependency of FS_WC_Migration and FS_WC_Migration_Endpoint (that should be removed), I think you can get rid of this code at all.

vovafeldman · 2016-11-12T15:36:50Z

includes/migration/wc/class-fs-wc-migration.php

-				0,
-				32
-			);
+			return $this->ep->site_uid;


@shramee site_uid and install_id are NOT the same things. Please generate the install_id based on a similar structure I created the EDD insatll_id.

vovafeldman · 2016-11-12T15:42:49Z

includes/migration/wc/class-fs-wc-migration.php

-		protected static $_edd_sl;
-
+		/** @var FS_WC_Migration_Endpoint Instance */
+		protected $ep;


@shramee FS_WC_Migration and FS_WC_Migration_Endpoint were intentionally designed to be isolated classes. Based on reviewing your code, you are using $ep to access the order information. I recommend removing this dependency and just passing the minimal arguments that you need to access the order data (based on what I've seen it's the customer email and license key).

vovafeldman · 2016-11-12T15:46:04Z

includes/migration/wc/class-fs-wc-migration.php

-			$purchase['payment_method']       = $this->get_local_purchase_gateway();
-			$purchase['customer_external_id'] = 'edd_customer_' . $this->_edd_customer->id;
-			$purchase['license_key']          = self::$_edd_sl->get_license_key( $this->_edd_license->ID ); // Preserve the same keys.
+			$purchase['payment_method']       = $this->_wc_order->payment_method;


@shramee what are the optional values of $this->_wc_order->payment_method? Because FS only accepts paypal and cc (for credit cards).

vovafeldman · 2016-11-12T15:47:32Z

includes/migration/wc/class-fs-wc-migration.php


-			if ( $this->local_is_sandbox_purchase() ) {
-				$purchase['is_sandbox'] = true;
+			if ( ! $purchase['payment_method'] ) {


@shramee in what scenario $this->_wc_order->payment_method can be empty?

When payment is not made (100% coupon)...

I used 100% coupon and FS api threw an error saying it can't be empty...

# Conflicts: # includes/entities/class-fs-entity-map.php # includes/migration/edd/class-fs-edd-download-migration.php # samples/module-migration.php

and… `get_local_license_id` now uses download `permission_id`

and fixing `FS_WC_Migration_Endpoint::get_local_paid_plan_id()`

should be either `paypal` or `cc`

vovafeldman and others added 17 commits October 4, 2016 18:59

Merge pull request #1 from Freemius/develop

be7a831

Develop

Merge pull request #2 from Freemius/develop

cee6264

Develop

Merge pull request Freemius#3 from Freemius/develop

6d23b32

Develop

Merge pull request #1 from Freemius/feature/woocommerce

42c7465

Feature/woocommerce

Removing EDD and adding WC in /includes/*

13cc199

Not including the `migrate` directory. Searched and replaced EDD naming with WC…

Admin settings and templates for WC

b12adcf

Sample file

20ef811

Plugin root files naming

0f915ac

Order array example

242ff6a

Plugin activation redirection and correcting namespace

e13b34c

and correcting `WP_FS__NAMESPACE_WC`

EDD > WC in file docs

cad67e1

Updating FS_Entity_Map

c408994

New content provided by Vova over Slack…

Subscriptions not implemented Exception...

e79dae9

WC Product to FS plugin and plans

41c165a

Migration endpoint changes

867bbaf

FS_WC_Migration class

9ab0cdb

Undefined function

2aa8aae

Call to undefined function print_awesome_r()

This is an abstract class, so it shouldn't be specifically associated…

cabff66

… with any platform.

vovafeldman reviewed Nov 12, 2016

View reviewed changes

shramee added 8 commits November 15, 2016 11:58

Merge remote-tracking branch 'Freemius/feature/woocommerce'

0fc17f0

# Conflicts: # includes/entities/class-fs-entity-map.php # includes/migration/edd/class-fs-edd-download-migration.php # samples/module-migration.php

Merge remote-tracking branch 'origin/master'

7752d5a

Resolving conflicts

b46abb6

User's email not read for migration

1deafc2

and… `get_local_license_id` now uses download `permission_id`

Fixing local pricing id, billing cycle and license quota

591318d

Get correct ID even if products have same Software Title

7354ce0

and fixing `FS_WC_Migration_Endpoint::get_local_paid_plan_id()`

Email not used in API

c443ab8

Unknown payment method error

2a6ea37

should be either `paypal` or `cc`

Conversation

shramee commented Nov 11, 2016

Uh oh!

shramee commented Nov 11, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants